Re: [PATCH v2 0/3] Some add-on patches on top of dj/runtime-prefix
From: Junio C Hamano <hidden>
Date: 2018-04-24 01:44:33
Johannes Schindelin [off-list ref] writes:
We carried a slightly different version of the git_setup_gettext() patch (which took care of releasing the buffer allocated by system_path()), and we carry two more patches that touch the same area, so now that dj/runtime-prefix hit `next`, it seems a good time to contribute those, too. Changes since v1: - clarified in v1 why we cannot simply force users to recompile with NO_GETTEXT instead. Johannes Schindelin (2): gettext: avoid initialization if the locale dir is not present git_setup_gettext: plug memory leak Philip Oakley (1): Avoid multiple PREFIX definitions Makefile | 2 +- exec-cmd.c | 4 ++-- gettext.c | 10 +++++++++- sideband.c | 10 +++++----- 4 files changed, 17 insertions(+), 9 deletions(-) base-commit: b46fe60e1d7235603a29499822493bd3791195da
Basing your work on the tip of 'next' is good for discussion, but not readily usable for final application. Let me see if I can untangle the dependents to come up with a reasonable base. The changes themselves looked reasonable. Thanks.