Re: What's cooking in git.git (Apr 2018, #02; Tue, 17)
From: Jonathan Tan <hidden>
Date: 2018-04-18 13:09:54
On Tue, Apr 17, 2018 at 11:05 AM, Stefan Beller [off-list ref] wrote:
quoted
* sb/submodule-move-nested (2018-03-29) 6 commits - submodule: fixup nested submodules after moving the submodule - submodule-config: remove submodule_from_cache - submodule-config: add repository argument to submodule_from_{name, path} - submodule-config: allow submodule_free to handle arbitrary repositories - grep: remove "repo" arg from non-supporting funcs - submodule.h: drop declaration of connect_work_tree_and_git_dir Moving a submodule that itself has submodule in it with "git mv" forgot to make necessary adjustment to the nested sub-submodules; now the codepath learned to recurse into the submodules. What's the doneness of this thing?I considered this done a long time ago, "All 6 patches look good to me, thanks. Reviewed-by: Jonathan Tan [off-list ref]" https://public-inbox.org/git/20180328161727.af10f596dffc8e01205c41dd@google.com/
To add to this, I sent this in reply to version 3 of this patch set, after Stefan addressed my comments. Most of my in-depth comments were in reply to version 1 of this patch, which are the grandchild replies to [1]. [1] https://public-inbox.org/git/20180327213918.77851-1-sbeller@google.com/