Thread (1 message) 1 message, 1 author, 2018-04-10

Re: git remote rename problem with trailing \\ for remote.url config entries (on Windows)

From: Junio C Hamano <hidden>
Date: 2018-04-10 23:31:24

Johannes Schindelin [off-list ref] writes:
A quick test with my `empty-config-section` patch series shows that it
addresses this issue. A quick bisec confirms that the patch with the
online "git_config_set: make use of the config parser's event stream" is
responsible for this fix.

At first, I was puzzled by this, because I expected `git remote rename` to
be backed by the `git_config_copy_or_rename_section_in_file()` function
(which my patch series does not touch).
I played around with this test data:

        [sec "tio"]
                val = a\\
                ue = b

and saw "git config --rename-section sec.tio sec.tion" just work
fine (without the event stream change).  Without the event stream
change, "git config --unset sec.tio.ue" loses "sec.tio.val" but with
it we see we only lose the last line, which is the correct thing to
happen.

Nice.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help