Re: [PATCH v7 08/14] commit-graph: implement git commit-graph read
From: Jakub Narebski <hidden>
Date: 2018-04-08 13:00:07
Derrick Stolee [off-list ref] writes: [...]
quoted hunk
EXAMPLES --------@@ -45,6 +51,12 @@ EXAMPLES $ git commit-graph write ------------------------------------------------ +* Read basic information from the commit-graph file. ++ +------------------------------------------------ +$ git commit-graph read +------------------------------------------------
It would be better to have example output of this command here, perhaps together with ASCII-art diagram of the code graph. [...]
+ if (!graph)
+ die("graph file %s does not exist", graph_name);
+ FREE_AND_NULL(graph_name);Shouldn't the error message be marked up for translation, too? Regards, -- Jakub Narębski