Re: [GSoC][PATCH v5] test: avoid pipes in git related commands for test

Eric Sunshine [off-list ref] writes:

On Tue, Mar 27, 2018 at 1:31 PM, Pratik Karki [off-list ref] wrote:

quoted

Avoid using pipes downstream of Git commands since the exit codes
of commands upstream of pipes get swallowed, thus potentially
hiding failure of those commands. Instead, capture Git command
output to a file and apply the downstream command(s) to that file.


Signed-off-by: Pratik Karki <redacted>

Unnecessary double blank line above sign-off.

"git am" would automatically trigger stripspace, which would eat the
extra blank line from that two-blank-line block.

Aside from that minor hiccup (which Junio fixed when queuing), this
iteration addresses all my review comments[1] from the previous round
and does not seem to introduce any new issues.

Thanks for a review.