Re: [PATCH v2 2/5] trace.c: export trace_setup_key

On Fri, Mar 30, 2018 at 12:50:50PM -0700, Junio C Hamano wrote:

Jeff King [off-list ref] writes:

quoted

On Fri, Mar 30, 2018 at 12:46:26PM -0700, Junio C Hamano wrote:

quoted

Jeff King [off-list ref] writes:

quoted

From: Nguyễn Thái Ngọc Duy <redacted>

This is so that we can print traces based on this key outside trace.c.

"this key" meaning...?  GIT_TRACE_SETUP?

I think "based on trace_setup_key".

-Peff

Yeah, I read, but did not pay enough attention to, the subject X-<.

To be fair, one of our guidelines is that the commit message should not
overly rely on the subject line. Though I am certainly guilty of
starting many a message with "This".

Perhaps:

  The setup-tracing code is static-local to trace.c. In preparation for
  new GIT_TRACE_SETUP code outside of trace.c, let's make the trace_key
  globally available.

would be a better commit message.

-Peff