Thread (1 message) 1 message, 1 author, 2018-03-30

Re: [PATCH] config: move flockfile() closer to unlocked functions

From: Junio C Hamano <hidden>
Date: 2018-03-30 19:52:17

Jeff King [off-list ref] writes:
On Fri, Mar 30, 2018 at 09:04:13PM +0200, Johannes Schindelin wrote:
quoted
quoted
Probably the flockfile should go into do_config_from_file(), where we
specify to use the unlocked variants.
Ah, that makes sense now! I am glad I could also help ;-)
:)
quoted
quoted
Yeah, I'll wait to see how your refactor turns out.
I don't think I'll touch too much in that part of the code. My changes
should not cause merge conflicts with a patch moving the
flockfile()/funlockfile() calls to do_config_from_file().
OK, then let's do this while we're thinking about it:
Yup, what Dscho found was quite amusing ;-) and this obviously makes
the code clearer to follow.

Will queue, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help