Thread (94 messages) 94 messages, 6 authors, 2018-05-08

Re: [PATCH 0/9] Assorted fixes for `git config` (including the "empty sections" bug)

From: Stefan Beller <hidden>
Date: 2018-03-29 17:58:49

On Thu, Mar 29, 2018 at 8:18 AM, Johannes Schindelin
[off-list ref] wrote:
So what is the argument against this extra care to detect comments? Well, if
you have something like this:

        [section]
                ; Here we comment about the variable called snarf
                snarf = froop

and we run `git config --unset section.snarf`, we end up with this config:

        [section]
                ; Here we comment about the variable called snarf

which obviously does not make sense. However, that is already established
behavior for quite a few years, and I do not even try to think of a way how
this could be solved.
By commenting out the key/value pair instead of deleting it.
It's called --unset, not --delete ;)

Now onto reviewing the patches.

Stefan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help