Thread (11 messages) flat view 11 messages, 4 authors, 2018-03-28

Re: [PATCH] submodule: check for NULL return of get_submodule_ref_store()

From: Stefan Beller <hidden>
Date: 2018-03-28 21:37:37

This looks nicer here in the script, but doesn't test exactly what users
type most of the time, I suppose.

So how about this?
Looks good to me, though I had a nagging feeling at first that the
regex could be made more concise.
Why do we need the optional "[^ ]" inside \1 ?
+       sed -e "s/^ \([^ ]* repo\) .*/-\1/" <actual >expect &&
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help