Re: [PATCH v3 2/5] stash: convert apply to builtin
From: Johannes Schindelin <hidden>
Date: 2018-03-27 15:07:26
From: Johannes Schindelin <hidden>
Date: 2018-03-27 15:07:26
Hi Joel, On Mon, 26 Mar 2018, Joel Teichroeb wrote:
Add a bulitin helper for performing stash commands. Converting all at once proved hard to review, so starting with just apply let conversion get started without the other command being finished. The helper is being implemented as a drop in replacement for stash so that when it is complete it can simply be renamed and the shell script deleted. Delete the contents of the apply_stash shell function and replace it with a call to stash--helper apply until pop is also converted. Signed-off-by: Joel Teichroeb <redacted>
Very good! In the interest of as incremental a change as possible, I would wager a bet that this is the best way we can go about it, later replacing the parts that still spawn Git processes (such as get_symbolic_name and have_stash) with direct calls into libgit.a, one by one. Thank you! Dscho