[PATCH/RFC 1/5] git.c: convert --list-builtins to --list-cmds=builtins
From: Nguyễn Thái Ngọc Duy <hidden>
Date: 2018-03-26 16:56:15
Subsystem:
the rest · Maintainer:
Linus Torvalds
Even if this is a hidden option, let's make it a bit more generic since we're introducing more listing types. Signed-off-by: Nguyễn Thái Ngọc Duy <redacted> --- git.c | 7 +++++-- t/t0012-help.sh | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/git.c b/git.c
index ceaa58ef40..f350002260 100644
--- a/git.c
+++ b/git.c@@ -205,8 +205,11 @@ static int handle_options(const char ***argv, int *argc, int *envchanged) } (*argv)++; (*argc)--; - } else if (!strcmp(cmd, "--list-builtins")) { - list_builtins(); + } else if (skip_prefix(cmd, "--list-cmds=", &cmd)) { + if (!strcmp(cmd, "builtins")) + list_builtins(); + else + die("unsupported command listing type '%s'", cmd); exit(0); } else { fprintf(stderr, _("unknown option: %s\n"), cmd);
diff --git a/t/t0012-help.sh b/t/t0012-help.sh
index 487b92a5de..fd2a7f27dc 100755
--- a/t/t0012-help.sh
+++ b/t/t0012-help.sh@@ -50,7 +50,7 @@ test_expect_success "--help does not work for guides" " " test_expect_success 'generate builtin list' ' - git --list-builtins >builtins + git --list-cmds=builtins >builtins ' while read builtin
--
2.17.0.rc0.348.gd5a49e0b6f