Thread (15 messages) 15 messages, 3 authors, 2018-03-27

Re: [PATCH v7 0/3] RUNTIME_PREFIX relocatable Git

From: Daniel Jacques <hidden>
Date: 2018-03-26 14:55:21

On Mon, Mar 26, 2018 at 10:08 AM Ævar Arnfjörð Bjarmason [off-list ref]
wrote:
quoted
Oh sorry, I must have missed that. I have a personal preference for
adding
quoted
brackets for clarity; it leaked into this patch set. I did implement
most
quoted
of the suggestion, which was to use the escaped Q/E instead of equals.

Stylistically I still prefer the braces, but I'll defer to you and
remove
quoted
them in my pending patch set in case I'm asked to submit another
version.
If you prefer it that way just keep your version. It's your code and
it's just a trivial style difference.
I just mentioned it because in the previous discussion you said "I agree
it's cleaner" so I inferred that you'd just forgotten about it but meant
to change it. It's also fine if later you just thought "you know what,
I'm doing it my way" :)
Honestly there's enough of a delay here that I don't remember, but if I had
to guess I probably just forgot to make the change :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help