Re: [PATCH 0/4] Convert some stash functionality to a builtin
From: Thomas Gummerer <hidden>
Date: 2018-03-25 17:35:59
On 03/24, Joel Teichroeb wrote:
I've been working on converting all of git stash to be a builtin, however it's hard to get it all working at once with limited time, so I've moved around half of it to a new stash--helper builtin and called these functions from the shell script. Once this is stabalized, it should be easier to convert the rest of the commands one at a time without breaking anything. I've sent most of this code before, but that was targetting a full replacement of stash. The code is overall the same, but with some code review changes and updates for internal api changes.
Thanks for splitting this up into multiple patches, I found that much more pleasant to review, and thanks for your continued work on this :)
Since there seems to be interest from GSOC students who want to work on converting builtins, I figured I should finish what I have that works now so they could build on top of it. Joel Teichroeb (4): stash: convert apply to builtin stash: convert branch to builtin stash: convert drop and clear to builtin stash: convert pop to builtin .gitignore | 1 + Makefile | 1 + builtin.h | 1 + builtin/stash--helper.c | 514 ++++++++++++++++++++++++++++++++++++++++++++++++ git-stash.sh | 13 +- git.c | 1 + 6 files changed, 526 insertions(+), 5 deletions(-) create mode 100644 builtin/stash--helper.c -- 2.16.2