Thread (2 messages) flat view 2 messages, 2 authors, 2018-03-22

Re: [PATCH] filter-branch: consider refs can refer to an object other than commit or tag

From: Junio C Hamano <hidden>
Date: 2018-03-21 20:00:58

Yuki Kokubun [off-list ref] writes:
quoted
Yuki Kokubun [off-list ref] writes:
quoted
"git filter-branch -- --all" can be confused when refs that refer to objects
other than commits or tags exists.
Because "git rev-parse --all" that is internally used can return refs that
refer to an object other than commit or tag. But it is not considered in the
phase of updating refs.
Could you describe what the consequence of that is?  We have a ref
that points directly at a blob object, or a ref that points at a tag
object that points at a blob object.  The current code leaves both of
these refs in "$tempdir/heads".  Then...?
Sorry, this is my wrong.
I wrongly thought only refs/replace can point at a blob or tree object.
No need to be sorry.  You still need to describe what (bad things)
happen if we do not filter out refs that do not point at committish
in the proposed log message.  

IOW, can you elaborate and clarify your "can be confused" at the
beginning?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help