Thread (18 messages) flat view 18 messages, 5 authors, 2018-04-15

Re: [PATCH v11 10/10] convert: add round trip check based on 'core.checkRoundtripEncoding'

From: Eric Sunshine <hidden>
Date: 2018-03-09 20:18:14

On Fri, Mar 9, 2018 at 12:35 PM,  [off-list ref] wrote:
quoted hunk ↗ jump to hunk
[...]
Add 'core.checkRoundtripEncoding', which contains a comma separated
list of encodings, to define for what encodings Git should check the
conversion round trip if they are used in the 'working-tree-encoding'
attribute.
[...]
Signed-off-by: Lars Schneider <redacted>
---
diff --git a/convert.c b/convert.c
@@ -1150,7 +1227,7 @@ static const char *git_path_check_encoding(struct attr_check_item *check)
        /* Don't encode to the default encoding */
-       if (!strcasecmp(value, default_encoding))
+       if (is_encoding_utf8(value) && is_encoding_utf8(default_encoding))
                return NULL;
This change belongs in 6/10, not 10/10, methinks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help