RE: [Problem] test_must_fail makes possibly questionable assumptions about exit_code.

On March 1, 2018 2:36 AM, Jeff King wrote:

On Wed, Feb 28, 2018 at 05:51:14PM +0100, demerphq wrote:

quoted

I would look into putting it into a module and then using the PERL5OPT
environment var to have it loaded automagically in any of your perl
scripts.

For instance if you put that code into a module called Git/DieTrap.pm

then you could do:

PERL5OPT=-MGit::DieTrap

In your test setup code assuming you have some. Then you don't need to
change any of your scripts just the test runner framework.

That's a clever trick.

It's not clear to me though if we just want to tweak the programs run in the
test scripts in order to get test_must_fail to stop complaining, or if we
consider the unusual exit codes from our perl-based Git programs to be an
error that should be fixed for real use, too.

I'm living unusual exit code IRL all the time. So "fixed for real", is what I'm looking for. So if we were to do that, where is the best place to insert a fix - my original question - that would be permanent in the main git test code. Or perhaps this needs to be in the main code itself.

Cheers,
Randall