Thread (1 message) 1 message, 1 author, 2018-02-27

Re: [PATCH v3 14/35] connect: request remote refs using v2

From: Junio C Hamano <hidden>
Date: 2018-02-27 23:32:43

Jeff King [off-list ref] writes:
quoted
struct strs {...};

void strs_init(struct strs *);
void strs_push(struct strs *, const char *);
void strs_pushf(struct strs *, const char *fmt, ...);
void strs_pushl(struct strs *, ...);
void strs_pushv(struct strs *, const char **);
void strs_pop(struct strs *);
void strs_clear(struct strs *);
const char **strs_detach(struct strs *);

...is short, feels pretty natural, and doesn't require understanding
"v" for "vector".
Not bad. The "v" carries the information that it _is_ a NULL-terminated
vector and not some other list-like structure (and so is suitable for
feeding to execv, etc). But that may just be obvious from looking at its
uses and documentation.
And with "v", it probably is obvious without looking at its uses and
documentation, so... ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help