Re: [PATCH v3 0/6] Fix initializing the_hash_algo

On Sun, Feb 25, 2018 at 12:34 PM, brian m. carlson
[off-list ref] wrote:

On Sun, Feb 25, 2018 at 06:18:34PM +0700, Nguyễn Thái Ngọc Duy wrote:

quoted

v3 refines v2 a bit more:

- fix configure typo (and stray words in commit message)
- use repo_set_hash_algo() instead of reassigning the_hash_algo
- compare hash algos by format_id
- catch NULL hash algo, report nicely and suggest GIT_HASH_FIXUP

The last point makes me much happier about keeping this workaround
around until we are confident we can live without it. Interdiff

This looks sane to me.

Reviewed-by: brian m. carlson <redacted>

I agree with this version as well.

Thanks,
Stefan