Re: [PATCH 0/4] Delete ignore_env member in struct repository
From: Junio C Hamano <hidden>
Date: 2018-02-26 18:08:05
Nguyễn Thái Ngọc Duy [off-list ref] writes:
This series is built on top of Stefan's object-store-part1, v4. I could rebase it on 'master' too, but then Junio may need to resolve some conflicts.
As a follow-up fix for combined "move things to the_repo as much as possible" efforts I think what you did makes most sense. I would say that it makes even more sense to make these part of the object-store series if/when the series needs rerolling--after all the topic is already a multi-author effort. I'll have to read them carefully before commenting on the actual patches ;-) Thanks.
[1] https://public-inbox.org/git/20180225111840.16421-1-pclouds@gmail.com/ Nguyễn Thái Ngọc Duy (4): repository.c: move env-related setup code back to environment.c repository.c: delete dead functions sha1_file.c: move delayed getenv(altdb) back to setup_git_env() repository: delete ignore_env member cache.h | 2 +- environment.c | 13 +++++++-- object-store.h | 5 +++- object.c | 1 + repository.c | 79 ++++++++++++++++++++++---------------------------- repository.h | 21 +++++++------- setup.c | 3 +- sha1_file.c | 6 +--- 8 files changed, 64 insertions(+), 66 deletions(-)