[PATCH 0/3] a few grep patches · Rasmus Villemoes <hidden> · 2018-02-15
[PATCH 1/3] grep: move grep_source_init outside critical section · Rasmus Villemoes <hidden> · 2018-02-15
Re: [PATCH 1/3] grep: move grep_source_init outside critical section · Jeff King <hidden> · 2018-02-15
[PATCH 3/3] grep: avoid one strdup() per file · Rasmus Villemoes <hidden> · 2018-02-15
Re: [PATCH 3/3] grep: avoid one strdup() per file · Jeff King <hidden> · 2018-02-15
[PATCH 2/3] grep: simplify grep_oid and grep_file · Rasmus Villemoes <hidden> · 2018-02-15
Re: [PATCH 0/3] a few grep patches · Brandon Williams <hidden> · 2018-02-15
[PATCH v2 0/2] two small grep patches · Rasmus Villemoes <hidden> · 2018-02-23
[PATCH v2 2/2] grep: simplify grep_oid and grep_file · Rasmus Villemoes <hidden> · 2018-02-23
[PATCH v2 1/2] grep: move grep_source_init outside critical section · Rasmus Villemoes <hidden> · 2018-02-23
Re: [PATCH v2 0/2] two small grep patches · Jeff King <hidden> · 2018-02-23

Re: [PATCH v2 0/2] two small grep patches

From: Jeff King <hidden>
Date: 2018-02-23 18:01:15

On Fri, Feb 23, 2018 at 03:47:55PM +0100, Rasmus Villemoes wrote:

Changes in v2:

- Drop patch 3 with dubious gain/complexity ratio
- Add comments regarding ownership of grep_source

I was a little torn between copy-pasting the comment or just saying
"see above" in the second case. I think a memset would be confusing,
at least unless one extends the comment to explain why one then does
the memset despite the first half of the comment.

This looks good to me. Thanks for following up.

-Peff

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help