Re: [PATCH v2 1/9] add -i: add function to format hunk header
From: Junio C Hamano <hidden>
Date: 2018-02-20 18:21:10
Phillip Wood [off-list ref] writes:
quoted hunk
From: Phillip Wood <redacted> This code is duplicated in a couple of places so make it into a function as we're going to add some more callers shortly. Signed-off-by: Phillip Wood <redacted> --- git-add--interactive.perl | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)diff --git a/git-add--interactive.perl b/git-add--interactive.perl index 964c3a75420db4751cf11125b68b6904112632f1..8ababa6453ac4f57a925aacbb8b9bb1c973e4a54 100755
This is quite a tangent, but please refrain from using full object name on the index line. Because it does not add much value in the context of patch exchange for project of this size to use more than 7-12 hexdigits each, the only effect of doing so is to push the mode bit far to the right.