Re: [PATCH v2 2/9] t3701: indent here documents
From: Eric Sunshine <hidden>
Date: 2018-02-19 18:36:47
On Mon, Feb 19, 2018 at 6:29 AM, Phillip Wood [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Phillip Wood <redacted> Indent here documents in line with the current style for tests. Signed-off-by: Phillip Wood <redacted> ---diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh@@ -22,14 +22,14 @@ test_expect_success 'status works (initial)' ' test_expect_success 'setup expected' ' -cat >expected <<EOF -new file mode 100644 -index 0000000..d95f3ad ---- /dev/null -+++ b/file -@@ -0,0 +1 @@ -+content -EOF + cat >expected <<-EOF
Minor: You could take the opportunity to update these to use -\EOF (rather than -EOF) to document that no variable interpolation is expected inside the 'here' document. Probably itself not worth a re-roll.
+ new file mode 100644 + index 0000000..d95f3ad + --- /dev/null + +++ b/file + @@ -0,0 +1 @@ + +content + EOF '