Thread (2 messages) 2 messages, 2 authors, 2018-02-13

Re: [PATCH 00/26] Moving global state into the repository object (part 1)

From: Junio C Hamano <hidden>
Date: 2018-02-13 19:35:28

Stefan Beller [off-list ref] writes:
For now the ignore_env bit lives in the repository, as that helps
when working with submodules, when reading its comments.
Unfortunately 359efeffc1 (repository: introduce the repository
object, 2017-06-22) did not reason about the existence of the ignore_env
flag in its commit message.
quoted
So from that point of view, it may not matter where the "bit" lives,
among repository, object-store, or ref-store.
It matters on the scale of confusing the developer?
What I meant is that from the point of view, having the bit in the
data (not on the invocation) is confusing no matter which data
structure holds it--they are equally bad.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help