Thread (100 messages) 100 messages, 4 authors, 2018-04-28

Re: [PATCH v2 3/3] worktree: teach "add" to check out existing branches

From: Thomas Gummerer <hidden>
Date: 2018-02-09 11:04:34

On 02/06, Duy Nguyen wrote:
On Tue, Feb 6, 2018 at 3:23 AM, Thomas Gummerer [off-list ref] wrote:
quoted
On 02/05, Duy Nguyen wrote:
quoted
On Sun, Feb 04, 2018 at 10:13:05PM +0000, Thomas Gummerer wrote:
quoted
-   if (opts->new_branch)
+   if (opts->checkout_existing_branch)
+           fprintf(stderr, _(", checking out existing branch '%s'"),
+                   refname);
+   else if (opts->new_branch)
            fprintf(stderr, _(", creating new branch '%s'"), opts->new_branch);
I wonder if "creating branch" and "checkout out branch" are enough.
I thought printing the branch name might be a good idea just to show
more clearly what the dwim did.
No no printing branch name is definitely a good idea, especially when
I think of one thing and type another. I shortened my example phrases
too much. It should have been "creating branch %s" and "checkout out
branch %s"
Ah sorry I misunderstood.  Yeah I think that makes sense then :)
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help