Thread (94 messages) flat view 94 messages, 4 authors, 2018-02-09

Re: [PATCH v2 02/17] fetch: trivially refactor assignment to ref_nr

From: Eric Sunshine <hidden>
Date: 2018-02-09 04:41:23

On Thu, Feb 8, 2018 at 11:19 AM, Ævar Arnfjörð Bjarmason
[off-list ref] wrote:
Trivially refactor an assignment to make a subsequent patch
smaller. The "ref_nr" variable is initialized to 0 earlier, just as
"j" is, and "j" is only incremented in that loop, so this change isn't
a logic error.

This change makes a subsequent change which splits the incrementing of
"ref_nr" into two blocks.
"This change _simplifies_ a subsequent..."

or

"This change make a subsequent change _easier_..."
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help