Thread (1 message) 1 message, 1 author, 2018-02-02

Re: [PATCH v2 01/12] hash: move SHA-1 macros to hash.h

From: Junio C Hamano <hidden>
Date: 2018-02-02 19:39:30

"brian m. carlson" [off-list ref] writes:
+#ifndef platform_SHA_CTX
+/*
+ * platform's underlying implementation of SHA-1; could be OpenSSL,
+ * blk_SHA, Apple CommonCrypto, etc...  Note that including
+ * SHA1_HEADER may have already defined platform_SHA_CTX for our
+ * own implementations like block-sha1 and ppc-sha1, so we list
+ * the default for OpenSSL compatible SHA-1 implementations here.
+ */
This nit has been with us for a long time, but "Note that including
SHA1_HEADER may have..." has been way too stale a comment for quite
some time.  It was made different from "including SHA1_HEADER" by
f18f816c ("hash.h: move SHA-1 implementation selection into a header
file", 2017-03-11).

Perhaps

	Note that we may have already defined platform_SHA_CTX for our
	own implementations like block-sha1 and ppc-sha1, so we list
	...

or something.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help