[PATCH v5 06/10] wildmatch test: use test_must_fail, not ! for test-wildmatch
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2018-01-30 21:22:10
Subsystem:
the rest · Maintainer:
Linus Torvalds
Use of ! should be reserved for non-git programs that are assumed not to fail, see README. With this change only t/t0110-urlmatch-normalization.sh is still using this anti-pattern. Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- t/t3070-wildmatch.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
index 2f8a681c72..fe0e5103a3 100755
--- a/t/t3070-wildmatch.sh
+++ b/t/t3070-wildmatch.sh@@ -13,7 +13,7 @@ match() { elif test "$1" = 0 then test_expect_success "wildmatch: no match '$2' '$3'" " - ! test-wildmatch wildmatch '$2' '$3' + test_must_fail test-wildmatch wildmatch '$2' '$3' " else test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'
@@ -29,7 +29,7 @@ imatch() { elif test "$1" = 0 then test_expect_success "iwildmatch: no match '$2' '$3'" " - ! test-wildmatch iwildmatch '$2' '$3' + test_must_fail test-wildmatch iwildmatch '$2' '$3' " else test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'
@@ -45,7 +45,7 @@ pathmatch() { elif test "$1" = 0 then test_expect_success "pathmatch: no match '$2' '$3'" " - ! test-wildmatch pathmatch '$2' '$3' + test_must_fail test-wildmatch pathmatch '$2' '$3' " else test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'
--
2.15.1.424.g9478a66081