Thread (1 message) 1 message, 1 author, 2018-01-22

Re: [PATCH] Fix comma splices

From: Junio C Hamano <hidden>
Date: 2018-01-22 23:23:07

Jeff King [off-list ref] writes:
(To be pedantic, these aren't comma splices. A comma splice joins two
independent clauses with a comma and _without_ a conjunction).
Thanks for clearing up the "Huh?" I felt earlier when I threw the
patch to "to look at later" bin after finding updated text for most
of them read not much better than the original, at least to me.

So I am OK to take this patch (or an updated version), but the log
message needs updating, I guess.
  2. Is this Q_() here actually helping? It triggers on "ours + theirs"
  ...
     In fact, I don't think the singular case here can _ever_ trigger,
Exactly.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help