RE: [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509
From: Randall S. Becker <hidden>
Date: 2018-01-11 06:01:36
On January 11, 2018 12:40 AM, I wrote:
quoted hunk ↗ jump to hunk
Subject: [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509 This fix was needed on HPE NonStop NSE where SSIZE_MAX is less than BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c was the only place outside of wrapper.c. Signed-off-by: Randall S. Becker <redacted> --- transport-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/transport-helper.c b/transport-helper.c index 3640804..68a4e30 100644 --- a/transport-helper.c +++ b/transport-helper.c@@ -1202,7 +1202,7 @@ static int udt_do_read(structunidirectional_transfer *t) return 0; /* No space for more. */ transfer_debug("%s is readable", t->src_name); - bytes = read(t->src, t->buf + t->bufuse, BUFFERSIZE - t->bufuse); + bytes = xread(t->src, t->buf + t->bufuse, BUFFERSIZE - t->bufuse); if (bytes < 0 && errno != EWOULDBLOCK && errno != EAGAIN && errno != EINTR) { error_errno("read(%s) failed", t->src_name);
This fixes all known breaks except 3 on NonStop down from 229, so I'm thinking it's worth it. A high fix-to-bytes-changed ratio 😉 Cheers, Randall