Re: [PATCH v2] t3900: add some more quotes
From: Johannes Schindelin <hidden>
Date: 2018-01-10 23:09:36
Hi Beat, On Wed, 10 Jan 2018, Beat Bolli wrote:
quoted hunk ↗ jump to hunk
diff --git a/t/t3900-i18n-commit.sh b/t/t3900-i18n-commit.sh index 9e4e694d9..dc00db87b 100755 --- a/t/t3900-i18n-commit.sh +++ b/t/t3900-i18n-commit.sh@@ -40,7 +40,7 @@ test_expect_success 'UTF-16 refused because of NULs' ' ' test_expect_success 'UTF-8 invalid characters refused' ' - test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" && + test_when_finished "rm -f \"$HOME/stderr\" \"$HOME/invalid\"" &&
It is probably worth quoting the dollar characters, too, as pointed out by Hannes Sixt: we want to interpolate the value only when needed, just in case that the HOME variable contains double quotes. Ciao, Dscho