Re: [ANNOUNCE] Git v2.16.0-rc1
From: Junio C Hamano <hidden>
Date: 2018-01-09 21:43:10
Johannes Schindelin [off-list ref] writes:
quoted hunk
diff --git a/t/t0021/rot13-filter.pl b/t/t0021/rot13-filter.pl index f1678851de9..470107248eb 100644 --- a/t/t0021/rot13-filter.pl +++ b/t/t0021/rot13-filter.pl@@ -31,7 +31,22 @@ # use 5.008; -use lib (split(/:/, $ENV{GITPERLLIB})); +sub gitperllib { +... + if ($ENV{GITPERLLIB} =~ /;/) { + return split(/;/, $ENV{GITPERLLIB}); + } + return split(/:/, $ENV{GITPERLLIB}); +}
This cannot be the whole story for a few reasons. - In t/test-lib.sh we see this: GITPERLLIB="$GIT_BUILD_DIR"/perl/blib/lib:"$GIT_BUILD_DIR"/perl/blib/arch/auto/Git export GITPERLLIB If this part wants to split with ';', then the joining needs to be done with ';' to match, no? - In addition to t0021, there are similar split with colon in 0202, 9000 and 9700, yet I am getting the feeling that you observed the issue only in0021, to which I do not think of a good explanation why.