Re: [PATCH] travis-ci: build Git during the 'script' phase

On 08 Jan 2018, at 23:07, Junio C Hamano [off-list ref] wrote:

SZEDER Gábor [off-list ref] writes:

quoted

The reason why Travis CI does it this way and why it's a better
approach than ours lies in how unsuccessful build jobs are
categorized.  ...
...
This makes it easier, both for humans looking at the Travis CI web
interface and for automated tools querying the Travis CI API,...
...
A verbose commit message for such a change... but I don't know why we
started with building Git in the 'before_script' phase.

Thanks for writing it up clearly.  TBH, I didn't even realize that
there were meaningful distinctions between the two cases after
seeing that sometimes our tests were failing and sometimes erroring
;-)

I understand the reasons for the proposed patch. However, I did this 
intentionally back then. Here is my reason:

If `make` is successful, then I am not interested in its output.
Look at this run: https://travis-ci.org/szeder/git/jobs/324271623

You have to scroll down 1,406 lines to get to the test result 
output (this is usually the interesting part).

If this is a valid argument for you, would it be an option to
pipe the verbose `make` output to a file and only print it in case
of error (we do something similar for the tests already).

- Lars