On Fri, Jan 5, 2018 at 12:31 PM, Thomas Gummerer [off-list ref] wrote:

On 01/04, Elijah Newren wrote:

quoted

On Wed, Jan 3, 2018 at 5:52 PM, SZEDER Gábor [off-list ref] wrote:

quoted

quoted

+             test $(git rev-parse :0:y/b) = $(git rev-parse O:z/b) &&

There is a test helper for that :)

  test_cmp_rev :0:y/b O:z/b

Note, that this is not only a matter of useful output on failure, but
also that of correctness and robustness.

Cool, good to know.  Is there any reason test_cmp_rev is not
documented in t/README?

It is documented since a few weeks, I added the docs in 5a0526264b
("t/README: document test_cmp_rev", 2017-11-26).  Though as people
mention they just look in 't/test-lib-functions.sh' anyway, maybe the
docs should live there instead of in the README in the first place?

Nice!  If we don't end up moving them, it might be nice to add a note
to point people towards t/test-lib-functions.sh from t/README,
mentioning that it might have other functions available as well.