Re: [PATCH] send-email: add test for Linux's get_maintainer.pl
From: Matthieu Moy <hidden>
Date: 2018-01-05 11:36:20
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2018-01-05 · Re: [PATCH] send-email: add test for Linux's get_maintainer.pl · Junio C Hamano <hidden>
- 2018-01-05 · Re: [PATCH] send-email: add test for Linux's get_maintainer.pl · Alex Bennée <hidden>
- 2018-01-05 · [PATCH] send-email: add test for Linux's get_maintainer.pl · Matthieu Moy <hidden>
Alex Bennée [off-list ref] writes:
I think you need to apply Eric's suggestions from: From: Eric Sunshine [off-list ref] Date: Sat, 18 Nov 2017 21:54:46 -0500 Message-ID: [ref]
Indeed. I'm squashing this into the patch:
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index f126177..d13d8c3 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh@@ -173,8 +173,7 @@ test_expect_success $PREREQ 'cc trailer with various syntax' ' ' test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc trailer' " - cat >expected-cc-script.sh <<-EOF && - #!/bin/sh + write_script expected-cc-script.sh <<-EOF && echo 'One Person <one@example.com> (supporter:THIS (FOO/bar))' echo 'Two Person <two@example.com> (maintainer:THIS THING)' echo 'Third List <three@example.com> (moderated list:THIS THING (FOO/bar))'
@@ -186,7 +185,6 @@ test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc trailer' " test_expect_success $PREREQ 'cc trailer with get_maintainer.pl output' ' - test_commit cc-trailer-getmaint && clean_fake_sendmail && git send-email -1 --to=recipient@example.com \ --cc-cmd="./expected-cc-script.sh" \
--
Matthieu Moy
https://matthieu-moy.fr/