Thread (33 messages) flat view 33 messages, 5 authors, 2018-01-02

Re: [PATCH v2 7/7] wt-status.c: avoid double renames in short/porcelain format

From: Igor Djordjevic <hidden>
Date: 2017-12-27 23:54:08

On 27/12/2017 01:49, Duy Nguyen wrote:
quoted
I lost you a bit here, partially because of what seems to be an
incomplete setup script, partially because of this last sentence, as
Git v2.15.1 doesn`t seem to be showing this, so not sure about "like
we have been showing until now" part...?
Yeah I missed a "git add -N third" in the setup. And "until now" was a
poor choice of words. It should have been "before 425a28e0a4", where
"new files" could not show up, which prevented rename detection in the
"Changed bot not staged for commit" section in the first place.
...
Sorry again about "now". Before 425a28e0a4 rename detection would not
kick in to find "second -> third" so people wouldn't know about rename
anyway.
Yeah, no worries, I had I hunch that it might be what you meant, but 
got too involved in all the rest that I forgot to bring that one up, 
too. Thanks for clarifying, though.

Regards, Buga
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help