Re: [PATCH] Fix confusing wording
From: Junio C Hamano <hidden>
Date: 2017-12-27 19:44:45
Ivan Pozdeev [off-list ref] writes:
Not sure if I should add a CVE-2009-0037 reference as well.
Not in an end-user facing message like this one, I would say.
---
Sign off?
quoted hunk
http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/http.c b/http.c index 215bebe..26b3386 100644 --- a/http.c +++ b/http.c@@ -802,7 +802,7 @@ static CURL *get_curl_handle(void)get_curl_allowed_protocols(-1)); #else warning("protocol restrictions not applied to curl redirects because\n" - "your curl version is too old (>= 7.19.4)"); + "your libcurl version is too old (< 7.19.4)"); #endif
Between 'curl' and 'libcurl', the latter certainly is more technically correct. I have a feeling that it would be better to spell out ">=" as "requires at least" than replacing it with equally cryptic "<" (it is OK to spell it out as "your libcurl version is older than minimum required 7.19.4", too). Thanks.