Re: [PATCH] Fix urlencode format string on signed char.
From: Junio C Hamano <hidden>
Date: 2017-12-22 21:48:58
Possibly related (same subject, not in this thread)
- 2017-12-22 · [PATCH] Fix urlencode format string on signed char. · Julien Dusser <hidden>
Julien Dusser [off-list ref] writes:
quoted hunk
Git credential fails with special char in password. remote: Invalid username or password. fatal: Authentication failed for File ~/.git-credential contains badly urlencoded characters %ffffffXX%ffffffYY instead of %XX%YY. Add a cast to an unsigned char to fix urlencode use of %02x on a char. Signed-off-by: Julien Dusser <redacted> --- strbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/strbuf.c b/strbuf.c index 323c49ceb..4d5a9ce55 100644 --- a/strbuf.c +++ b/strbuf.c@@ -658,7 +658,7 @@ static void strbuf_add_urlencode(struct strbuf *sb, const char *s, size_t len, (!reserved && is_rfc3986_reserved(ch))) strbuf_addch(sb, ch); else - strbuf_addf(sb, "%%%02x", ch); + strbuf_addf(sb, "%%%02x", (unsigned char)ch); } }
The issue is not limited to credential but anywhere where we need to show a byte with hi-bit set, and it is obvious and straight-forward. I briefly wondered if the data type for the strings involved in the codepaths that reach this place should all be "uchar*" but it feels strange to have "unsigned char *username" etc., and the signeness matters only here, so the patch smells like the best one among other possibilities. Thanks.