Re: [PATCH] sequencer: assign only free()able strings to gpg_sign

"phillip.wood@talktalk.net" [off-list ref] writes:

quoted

----Original Message----
From: johannes.schindelin@gmx.de
Date: 22/12/2017 11:50 
To: <redacted>
Cc: "Junio C Hamano"<redacted>, "Phillip Wood"<phillip.

wood@dunelm.org.uk>, "Kaartic Sivaraam"[off-list ref]

quoted

Subj: [PATCH] sequencer: assign only free()able strings to gpg_sign

The gpg_sign member of the replay_opts structure is of type `char *`,
meaning that the sequencer deems the string to which gpg_sign points 

to

quoted

be under its custody, i.e. it needs to be free()d by the sequencer.

Therefore, let's only assign malloc()ed buffers to it.

Reported-by: Kaartic Sivaraam <redacted>
Signed-off-by: Johannes Schindelin <redacted>
---

Phillip, if you want to squash these changes into your patches,
I'd totally fine with that.

Hi Johannes, thanks for putting this together, the patch it fixes is 
already in next so I think it'd be best to leave this one separate. I 
wonder if it would be worth adding another test, see below.

Thanks, both.  Let's queue this on top as a fix-up.