Thread (1 message) 1 message, 1 author, 2017-12-15

Re: [PATCH v2 0/2] Offer more information in `git version --build-options`'s output

From: Junio C Hamano <hidden>
Date: 2017-12-15 18:12:39

Eric Sunshine [off-list ref] writes:
On Fri, Dec 15, 2017 at 12:45 PM, Junio C Hamano [off-list ref] wrote:
quoted
Johannes Schindelin [off-list ref] writes:
quoted
      no commit associated with this build
I find this output somewhat klunky for machine parsing (and it is
inconsistent with the style used for "sizeof-long", which hints that
these are "<token> <colon> <value>" lines where whitespaces are
avoided in a <token>), but hopefully this is primarily for human
consumption and scrypts that are trying to find a specific piece of
information would know how to use 'grep', so the inconsistency does
not make much of a difference in practice anyway.
Simply omitting that line from the output of --build-options would
also be an option if the commit can not be determined...
What we see in Dscho's patch is better than that option, though.  At
least, explicitly checking for "no commit associated" would tell you
if the version of Git is too old to have "built from commit:" line
or it is new enough but was built from a tarball.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help