Re: What's cooking in git.git (Dec 2017, #03; Wed, 13)

On Thursday 14 December 2017 10:50 PM, Junio C Hamano wrote:

Kaartic Sivaraam [off-list ref] writes:

quoted

It seems my series that fixes an error message in 'git-rebase'[1]
(apart from a little cleanups) is missing. I guess I addressed the
issue that was raised in 3/3 as a v3 for that patch[2]. Are any more
changes needed?

[1]: [ref]
[2]: [ref]

I think you only sent 3/3 in newer rounds, which made it not to
apply to my tree. 

That's surprising, let me check.

If you meant to drop changes in 1/3 and 2/3,
perhaps because they were needless churn, then 3/3 needs to be
updated not to depend on the changes these two made.

2/3 is for sure not needless. But 1/3 might be. Though I think it improves the communicativity of the variable name. In case you think it's completely useless, then I can drop it as we won't lose much anyway ??


---
Kaartic