Re: [PATCH 1/2] git version --build-options: report the build platform, too

On Fri, Dec 8, 2017 at 4:17 PM, Eric Sunshine [off-list ref] wrote:

On Fri, Dec 8, 2017 at 12:43 PM, Junio C Hamano [off-list ref] wrote:

quoted

Jonathan Nieder [off-list ref] writes:

quoted

quoted

@@ -413,6 +414,7 @@ int cmd_version(int argc, const char **argv, const char *prefix)

     if (build_options) {
             printf("sizeof-long: %d\n", (int)sizeof(long));
+            printf("machine: %s\n", build_platform);

Can this use GIT_BUILD_PLATFORM directly instead of going via the indirection
of a mutable static string?  That is, something like

              printf("machine: %s\n", GIT_BUILD_PLATFORM);

Good point.  And if this is externally identified as "machine",
probably the macro should also use the same word, not "platform".
We can go either way, as long as we are consistent, though.

In Autoconf parlance, this would be called "host architecture" (GIT_HOST_ARCH).

My bad: "host cpu", rather (GIT_HOST_CPU).