Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

On 07 Dec 2017, at 16:48, Lars Schneider [off-list ref] wrote:

quoted

On 07 Dec 2017, at 16:43, Junio C Hamano [off-list ref] wrote:

lars.schneider@autodesk.com writes:
...

How about this?

			fprintf(stderr,
				_("hint: Waiting for your editor to close the file..."));
			if (is_terminal_dumb())
				/*
				 * A dumb terminal cannot erase the line later on. Add a
				 * newline to separate the hint from subsequent output.
				 */
				fprintf(stderr, "\n")
			else
				fprintf(stderr, " ")

I forgot the ";" ... switching between programming languages ;-)

			if (is_terminal_dumb())
				/*
				 * A dumb terminal cannot erase the line later on. Add a
				 * newline to separate the hint from subsequent output.
				 */
				fprintf(stderr, "\n");
			else
				fprintf(stderr, " ");

Can you squash that if you like it?

Thanks,
Lars