Thread (2 messages) flat view 2 messages, 2 authors, 2017-12-04

Re: [PATCH v2] Makefile: replace perl/Makefile.PL with simple make rules

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2017-12-04 18:08:31

On Mon, Dec 4, 2017 at 5:22 PM, Junio C Hamano [off-list ref] wrote:
I did this immediately after applying; please double check.

Thanks.
Thanks. Looks good to me. I'll incorporate that info future
submissions if there's more stuff to fix, but for now if you could
queue it like that that would be great.
1: da337670f5 ! 1: aeae85bdd0 Makefile: replace perl/Makefile.PL with simple make rules
    @@ -27,7 +27,7 @@
         So replace the whole thing with something that's pretty much a copy of
         how we generate po/build/**.mo from po/*.po, just with a small sed(1)
         command instead of msgfmt. As that's being done rename the files
    -    from *.pm to *.pmc just to indicate that they're genreated (see
    +    from *.pm to *.pmc just to indicate that they're generated (see
         "perldoc -f require").

         While I'm at it, change the fallback for Error.pm from being something
    @@ -50,9 +50,9 @@
            it could be set in addition to INSTLIBDIR, but my reading of [7] is
            that this is the desired behavior.

    -     * We don't man pages for all of the perl modules as we used t, only
    -       Git(3pm). As discussed on-list[8] that we were building installed
    -       manpages for purely internal APIs like Git::I18N or
    +     * We don't build man pages for all of the perl modules as we used to,
    +       only Git(3pm). As discussed on-list[8] that we were building
    +       installed manpages for purely internal APIs like Git::I18N or
            private-Error.pm was always a bug anyway, and all the Git::SVN::*
            ones say they're internal APIs.

:
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help