Thread (16 messages) flat view 16 messages, 3 authors, 2017-11-23

Re: [PATCH 0/3] Introduce BUG_ON(cond, msg) MACRO

From: Jeff King <hidden>
Date: 2017-11-23 00:10:54

On Wed, Nov 22, 2017 at 04:08:39PM -0800, Jonathan Nieder wrote:
quoted
For the record, I'm totally fine with banning assert() in favor of a
custom equivalent. I just don't think we've seen any real problems with
assert in our codebase so far.
It sounds like we basically agree, then. :)
Yeah, I didn't quite understand your argument at first. If it's that
asserts are potentially dangerous, I buy that. They haven't bit us, but
they could.

That would be a good thing for Stefan to put in his commit message. ;)

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help