Re: [PATCH 6/8] ssh: 'auto' variant to select between 'ssh' and 'simple'

Junio C Hamano wrote:

Jonathan Nieder [off-list ref] writes:

quoted

Android's "repo" tool is a tool for managing a large codebase
consisting of multiple smaller repositories, similar to Git's
submodule feature.  Starting with Git 94b8ae5a (ssh: introduce a
'simple' ssh variant, 2017-10-16), users noticed that it stopped
handling the port in ssh:// URLs.

...
Reported-by: William Yan <redacted>
Improved-by: Jonathan Tan [off-list ref]
Signed-off-by: Jonathan Nieder <redacted>
---

Not a big issue, but the above made me wonder, due to lack of any
signed-off-by before improved-by, what "base" was improved by JTan.
If you were writing a change before formally passing it around with
your sign-off and somebody had a valuable input to improve it, it
seems that people say helped-by around here.

Yep, I should have put the Improved-by after my sign-off.

Jonathan Tan's contribution was at
https://public-inbox.org/git/20171023151929.67165aea67353e5c24a15229@google.com/

[...]

quoted

+The config variable `ssh.variant` can be set to override this detection.
+Valid values are `ssh` (to use OpenSSH options), `plink`, `putty`,
+`tortoiseplink`, `simple` (no options except the host and remote command).
+The default auto-detection can be explicitly requested using the value
+`auto`.  Any other value is treated as `ssh`.  This setting can also be
+overridden via the environment variable `GIT_SSH_VARIANT`.
 +

Cleanly written and easily read.  Good.

i.e. that part is all thanks to him. :)

Jonathan