Thread (1 message) 1 message, 1 author, 2017-11-17

Re: [PATCH] launch_editor(): indicate that Git waits for user input

From: Junio C Hamano <hidden>
Date: 2017-11-17 01:09:35

Lars Schneider [off-list ref] writes:
quoted
On 16 Nov 2017, at 15:58, Junio C Hamano [off-list ref] wrote:

Lars Schneider [off-list ref] writes:
quoted
quoted
On 16 Nov 2017, at 07:04, Junio C Hamano [off-list ref] wrote:
Wow. Thanks for the quick patch :-)
Heh, this is not exactly my itch, so if you are inclined to, can you
take it over from here on?
Absolutely! What is the proper way to proceed here? Should I send a v2
with the changes I suggested? How do I attribute you correctly? I
assume I need to remove your 'Signed-off-by:'?
If you are making major changes over the original patch, you'd
probably want to take the authorship and mention me on Helped-by:
and/or add "This is based on a previous work by...", if you want to
credit me.

If you are not taking the authorship over, then doing something like

    https://public-inbox.org/git/xmqqshdex0ff.fsf@gitster.mtv.corp.google.com/

would be sufficient, I would think.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help