Thread (13 messages) flat view 13 messages, 6 authors, 2017-12-25

Re: [PATCH 1/2] sequencer: factor out rewrite_file()

From: Junio C Hamano <hidden>
Date: 2017-11-03 13:44:15

Possibly related (same subject, not in this thread)

Simon Ruderich [off-list ref] writes:
I tried looking into this by adding a new write_file_buf_gently()
(or maybe renaming write_file_buf to write_file_buf_or_die) and
using it from write_file_buf() but I don't know the proper way to
handle the error-case in write_file_buf(). Just calling
die("write_file_buf") feels ugly, as the real error was already
printed on screen by error_errno() and I didn't find any function
to just exit without writing a message (which still respects
die_routine). Suggestions welcome.
How about *not* printing the error at the place where you notice the
error, and instead return an error code to the caller to be noticed
which dies with an error message?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help