Re: [PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree
From: Ben Peart <hidden>
Date: 2017-10-26 19:56:33
On 10/25/2017 9:31 PM, Alex Vandiver wrote:
quoted hunk ↗ jump to hunk
The fsmonitor command inherits the PWD of its caller, which may be anywhere in the working copy. This makes is difficult for the fsmonitor command to operate on the whole repository. Specifically, for the watchman integration, this causes each subdirectory to get its own watch entry. Set the CWD to the top of the working directory, for consistency. Signed-off-by: Alex Vandiver <redacted> --- fsmonitor.c | 1 + 1 file changed, 1 insertion(+)diff --git a/fsmonitor.c b/fsmonitor.c index 7c1540c05..0d26ff34f 100644 --- a/fsmonitor.c +++ b/fsmonitor.c@@ -121,6 +121,7 @@ static int query_fsmonitor(int version, uint64_t last_update, struct strbuf *que argv[3] = NULL; cp.argv = argv; cp.use_shell = 1; + cp.dir = get_git_work_tree();
I'm not sure what would trigger this problem but I don't doubt that it is possible. Better to be safe than sorry. This is a better/faster solution than you're previous patch. Thank you!
return capture_command(&cp, query_result, 1024); }