Re: No log --no-decorate completion?

Just re-discovered this in my inbox. So is this worth fixing? I could
(probably) figure out a patch.

Thanks,
Max

On Thu, Oct 12, 2017 at 1:41 PM, Max Rothman [off-list ref] wrote:

To be fair, other --no* options complete, it's just --no-decorate,
--no-walk, --no-abbrev-commit, --no-expand-tabs, --no-patch,
--no-indent-heuristic, and --no-textconv that's missing.

For example:
$ git log --no<TAB><TAB>
--no-color         --no-max-parents   --no-min-parents   --no-prefix
     --not
--no-ext-diff      --no-merges        --no-notes         --no-renames
     --notes

Thanks,
Max

On Wed, Oct 11, 2017 at 2:09 PM, Stefan Beller [off-list ref] wrote:

quoted

On Wed, Oct 11, 2017 at 7:47 AM, Max Rothman [off-list ref] wrote:

quoted

I recently noticed that in the git-completion script, there's
completion for --decorate={full,yes,no} for git log and family, but
not for --no-decorate. Is that intentional? If not, I *think* I see
how it could be added.

Thanks,
Max

Using git-blame, I found af4e9e8c87 (completion: update am, commit, and log,
2009-10-07) as well as af16bdaa3f (completion: fix and update 'git log
--decorate='
options, 2015-05-01), both of their commit messages do not discuss leaving out
--no-decorate intentionally.

If you give --no-<TAB> you'd get more than just the completion to --no-decorate,
but all the negated options, I would assume?

So maybe that is why no one added the negated options, yet?

Thanks,
Stefan