Thread (1 message) 1 message, 1 author, 2017-10-22

Re: [PATCH v4] commit: check result of resolve_ref_unsafe

From: Junio C Hamano <hidden>
Date: 2017-10-22 00:47:03

Jeff King [off-list ref] writes:
quoted
Hello,
I think this way is better for user experience:
* git doesn't crash;
* warning is shown;
* commit has been successfully created then it's safe to show a summary message
with already known information and without resolved HEAD.
I'm on the fence between this and the die_errno() version. Given that
this would basically never happen in practice, I don't think it matters
too much. And that makes me want to just err on the side of simplicity.
But it's not like this is all that complex, either.
True.  I've queued v3 for now.

Thanks, both.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help